Skip to content

sigc++config.h.*: Update and clean up a bit for Visual Studio #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 5, 2023
Merged

sigc++config.h.*: Update and clean up a bit for Visual Studio #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0fcb87b
sigc++config.h.*: Drop Visual Studio noexcept workaround
fanc999-1 Jul 5, 2023
61ec29e
sigc++config.h.*: Update comment on MSVC warning C4251
fanc999-1 Jul 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions sigc++config.h.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@

#ifdef SIGC_MSC
/*
* MS VC7 Warning 4251 says that the classes to any member objects in an
* Visual C++ Warning C4251 says that the classes to any member objects in an
* exported class must also be exported. Some of the libsigc++
* template classes contain std::list members. MS KB article 168958 says
* that it's not possible to export a std::list instantiation due to some
Expand All @@ -46,11 +46,6 @@
*/
# pragma warning(disable:4251)

#if (_MSC_VER < 1900) && !defined (noexcept)
#define _ALLOW_KEYWORD_MACROS 1
#define noexcept _NOEXCEPT
#endif

#else /* SIGC_MSC */

#endif /* !SIGC_MSC */
Expand Down
7 changes: 1 addition & 6 deletions sigc++config.h.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@

#ifdef SIGC_MSC
/*
* MS VC7 Warning 4251 says that the classes to any member objects in an
* Visual C++ Warning C4251 says that the classes to any member objects in an
* exported class must also be exported. Some of the libsigc++
* template classes contain std::list members. MS KB article 168958 says
* that it's not possible to export a std::list instantiation due to some
Expand All @@ -46,11 +46,6 @@
*/
#pragma warning(disable : 4251)

#if (_MSC_VER < 1900) && !defined(noexcept)
#define _ALLOW_KEYWORD_MACROS 1
#define noexcept _NOEXCEPT
#endif

#else /* SIGC_MSC */

#endif /* !SIGC_MSC */
Expand Down
7 changes: 1 addition & 6 deletions sigc++config.h.meson
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

#ifdef SIGC_MSC
/*
* MS VC7 Warning 4251 says that the classes to any member objects in an
* Visual C++ Warning C4251 says that the classes to any member objects in an
* exported class must also be exported. Some of the libsigc++
* template classes contain std::list members. MS KB article 168958 says
* that it's not possible to export a std::list instantiation due to some
Expand All @@ -49,11 +49,6 @@
*/
#pragma warning(disable : 4251)

#if (_MSC_VER < 1900) && !defined(noexcept)
#define _ALLOW_KEYWORD_MACROS 1
#define noexcept _NOEXCEPT
#endif

#else /* SIGC_MSC */

#endif /* !SIGC_MSC */
Expand Down