This repository was archived by the owner on Oct 18, 2023. It is now read-only.
standalone sqld lib #485
Merged
standalone sqld lib #485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ae3d287 to
f5a64ff
Compare
d7f754b to
71e5a13
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits off the individual database components from sqld, and at the same time, makes it as portable as possible by exposing a blocking, single-threaded API.
The central moving part is the
Databasetrait that allows the creation of databaseConnection.Frame injection is possible on objects that implement
InjectableDatabase.Log compaction is external to the logging process: the logger calls the provided
LogCompactorto decide if compaction should be performed and perform it.I have added a bunch of tests as well.