cast sharpen image to int16

jcupitt · jcupitt · commit 7375fcf4c4d5 · 2024-09-12T13:53:51.000+01:00
We were assuming that if the input image was already labs, it was int16 labs. Thanks @CoachRDeveloper. See #4147
diff --git a/libvips/convolution/sharpen.c b/libvips/convolution/sharpen.c
@@ -199,8 +199,7 @@ vips_sharpen_build(VipsObject *object)
 	in = t[0];
 
 	if (vips_check_uncoded(class->nickname, in) ||
-		vips_check_bands_atleast(class->nickname, in, 3) ||
-		vips_check_format(class->nickname, in, VIPS_FORMAT_SHORT))
+		vips_check_bands_atleast(class->nickname, in, 3))
 		return -1;
 
 	/* Stop at 10% of max ... a bit mean. We always sharpen a short,
@@ -217,6 +216,12 @@ vips_sharpen_build(VipsObject *object)
 	vips_matrixprint(t[1], NULL);
 #endif /*DEBUG*/
 
+	/* Make sure we're short (need this for the LUT) and not eg. float LABS.
+	 */
+	if (vips_cast_short(in, &t[2], NULL))
+		return -1;
+	in = t[2];
+
 	/* Index with the signed difference between two 0 - 32767 images.
 	 */
 	if (!(sharpen->lut = VIPS_ARRAY(object, 65536, int)))
