Skip to content

nsgif copyright file is missing #2800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mika-fischer opened this issue May 12, 2022 · 3 comments
Closed

nsgif copyright file is missing #2800

mika-fischer opened this issue May 12, 2022 · 3 comments
Labels
bug

Comments

@mika-fischer
Copy link

See https://source.netsurf-browser.org/libnsgif.git/tree/COPYING

It should be present here https://github.com/libvips/libvips/tree/master/libvips/foreign/libnsgif
jcupitt added a commit that referenced this issue May 12, 2022
@jcupitt
add libnsgif COPYING
afb9ef0 
oops, we were missing the COPYING file

see #2800

thanks mika-fischer
@jcupitt
Copy link
Member

jcupitt commented May 12, 2022

Oooop, sorry about that. Thanks for pointing this out.

@jcupitt jcupitt closed this as completed May 12, 2022
@mika-fischer
Copy link
Author

Thanks for the quick fix, but was it on purpose to put the fix in the add-tiffsave_target and not in master?

jcupitt added a commit that referenced this issue May 12, 2022
@jcupitt
add libnsgif COPYING
7561d4e 
oops, we were missing the COPYING file

see #2800

thanks mika-fischer
@jcupitt
Copy link
Member

jcupitt commented May 12, 2022

🤦 it's either too much or too little coffee :( fixed now

jcupitt added a commit that referenced this issue May 20, 2022
@jcupitt
Add tiffsave target (#2798)
f8003bd 
* compiles, but untested

* works, but libtiff needs seek for write

next: add seek methods to target

* add target seek and read

seem to work

next: disc temps for disc output

* add libnsgif COPYING

oops, we were missing the COPYING file

see #2800

thanks mika-fischer

* tiffsave uses a disc temp if it can

* revise temp target rules

only make a disc temp if we are writing to a filesystem target

* add new target methods to targetcustom
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mika-fischer @jcupitt