Skip to content

jpeg save fails with scRGB data #2858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jcupitt opened this issue Jun 12, 2022 · 2 comments
Closed

jpeg save fails with scRGB data #2858

jcupitt opened this issue Jun 12, 2022 · 2 comments
Labels
bug
Milestone
8.14

Comments

@jcupitt
Copy link
Member

jcupitt commented Jun 12, 2022

Probably other similar savers too.

$ vips colourspace k2.jpg x.v scrgb
$ vips copy x.v x.jpg

Produces a black image.

VIPS_SAVEABLE_RGB_CMYK lets scRGB through, cast to uint8. Other savers need scRGB, so we can't just convert it. We should overhaul the SAVEABLE system, it's not very good.
@jcupitt jcupitt added the bug label Jun 12, 2022
@jcupitt jcupitt added this to the 8.14 milestone Jun 12, 2022
@jcupitt
Copy link
Member Author

jcupitt commented Jun 22, 2022

Actually, I've sort of bodged it in 8.13. Let's find something more interesting to work on instead.

@jcupitt jcupitt closed this as completed Jun 22, 2022
@DarthSim DarthSim mentioned this issue Jul 2, 2023
Closed
@kleisauke kleisauke mentioned this issue Aug 15, 2023
Closed
3 tasks
@kleisauke kleisauke mentioned this issue Aug 24, 2023
Merged
@jcupitt
Copy link
Member Author

jcupitt commented Oct 11, 2023

See #3623 for a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
8.14
Development

No branches or pull requests
1 participant
@jcupitt