Resolve rounding issues in reduce #1872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Kleis, this change looks good to me. |
|
Looks good here too, nice work Kleis. Sorry for being so slow on this. I finished my huge three-year project last night! \o/ so I should finally have some free time again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a split-off from #1769, targeting the
8.10branch.It fixes two small bugs that have been found with jsummers/resamplescope. The first commit (kleisauke@49d8051) restores the round-to-nearest behaviour in
reduce{h,v}, that was removed with PR #1592. This change can be observed in the following graphs:The second commit (kleisauke@fdc140e) rounds the sum values to the nearest integer in
*_notabversion. I'm not entirely sure why this is necessary and whether this is the right place to do it, but it seems to fix the double-precision graph:The last commit (kleisauke@4533375) rounds the
xandyvalues of thevips_embedcall up and take this offset into account (i.e. by subtracting it fromhoffset/voffset). Somehow I cannot illustrate this change within the graphs, but can confirm that this fixes the border-issues reported on sharp (lovell/sharp#2408 and lovell/sharp#2411). It also does not cause regressions on the pyvips-issue-148 and vips-issue-703 test repositories.