Add jpeg restart_interval option. #2468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows saving a jpeg with MCU restarts.
|
If I should adds tests, some advice on where to do it would be welcome. |
|
Hi @manthey, this is very cool, I'll have a look. Tests go here: https://github.com/libvips/libvips/blob/master/test/test-suite/test_foreign.py#L145 I suppose you'd want to test you can save and load, and that enabling restart increases the size of the saved object by a few bytes. |
jcupitt
reviewed
Oct 8, 2021
|
Thanks, @jcupitt. Let me know if you'd like any other changes. |
|
That's great! Thanks again. This will be in 8.12, due fairly soon, hopefully. |
|
... I added a test that images with MCU restarts can be loaded correctly. |
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows saving a jpeg with MCU restarts.