Skip to content

Revert "block fuzz data over 100kb" #3927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

kleisauke
Copy link
Member

This reverts commit cb1634d since https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=24383 was fixed with commit df26bd1 instead.


Note that timeouts and OOMs are only reported once per fuzz target, so this may cause duplicate reports.
https://google.github.io/oss-fuzz/faq/#how-do-you-handle-timeouts-and-ooms

@kleisauke
Copy link
Member Author

kleisauke commented Apr 8, 2024

My gut says that we should also remove/increase this check:

if (image->Xsize > 100 ||
image->Ysize > 100 ||
image->Bands > 4) {
g_object_unref(image);
return 0;
}

Given that it already ought to be covered by the unlimited open flag, which is not set during fuzzing.

@kleisauke
Copy link
Member Author

Ah, there is an extra * 1024 here, so the actual previous limit was 100 MiB.

Copy link
Member

@lovell lovell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try it and see. It's possible we might get some new problems from TIFF images, which #3892 should address.

@jcupitt jcupitt merged commit 60f49cf into libvips:master Apr 9, 2024
6 checks passed
@kleisauke kleisauke deleted the revert-cb1634d branch April 9, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants