conva: fix a crash with {u,}{short,int} images #4055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 18, 2024
Closed
|
Should we target the 8.15 branch for this (assuming a possible 8.15.3 release)? |
|
Good idea. Targeted against the |
lovell
approved these changes
Jul 18, 2024
{u,}{short,int} images should use {u,}short as an intermediate type
when the length of the longest line is below 256.
Resolves: libvips#1162.
|
CI will be fixed via PR #4057. |
|
Ah nice. Yes, I lost enthusiasm for approximate convolution and never really finished it :( Thanks for picking this up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{u,}{short,int} images should use {u,}short as an intermediate type when the length of the longest line is below 256.
Resolves: #1162.