Skip to content

heifsave: fix crash when passing an invalid bitdepth #4110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 24, 2024
Merged

heifsave: fix crash when passing an invalid bitdepth #4110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2147eb5
heifsave: fix crash when passing an invalid bitdepth
kleisauke Aug 24, 2024
ce3bbb9
Merge branch '8.15' into 8.15-heifsave-fix-invalid-bitdepth-crash
jcupitt Aug 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ChangeLog
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
8.15.4

- heifsave: fix crash when passing an invalid bitdepth
- fix an off-by-one error in vips__token_get()

11/8/24 8.15.3
Expand Down
4 changes: 2 additions & 2 deletions libvips/foreign/heifsave.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,10 +426,10 @@ vips_foreign_save_heif_pack(VipsForeignSaveHeif *heif,
}
}
else {
VipsObjectClass *class = VIPS_OBJECT_CLASS(heif);
VipsObjectClass *class = VIPS_OBJECT_GET_CLASS(heif);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦


vips_error(class->nickname,
"%s", _("unimplemeted format conversion"));
"%s", _("unimplemented format conversion"));
return -1;
}

Expand Down
Loading