Fix --vips-info CLI flag with GLib >= 2.80
#4251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `g_log_writer_default_set_debug_domains()` since resetting `G_MESSAGES_DEBUG` at runtime has no effect for GLib >= 2.80. Also, remove any checks for the old `G_MESSAGES_DEBUG` env variable and overwrite it directly instead. This means the `--vips-info` CLI flag and the `VIPS_INFO=1` env variable now take precedence over `G_MESSAGES_DEBUG`. See: https://gitlab.gnome.org/GNOME/glib/-/merge_requests/3710.
|
FWIW, |
|
I noticed it wasn't working, but I was too lazy to find out why :( Well done! |
kleisauke
added a commit
to kleisauke/libvips
that referenced
this pull request
Nov 17, 2024
jcupitt
pushed a commit
that referenced
this pull request
Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
g_log_writer_default_set_debug_domains()since resettingG_MESSAGES_DEBUGat runtime has no effect for GLib >= 2.80.Also, remove any checks for the old
G_MESSAGES_DEBUGenv variable and overwrite it directly instead. This means the--vips-infoCLI flag and theVIPS_INFO=1env variable now take precedence overG_MESSAGES_DEBUG.See: https://gitlab.gnome.org/GNOME/glib/-/merge_requests/3710.
Targets the 8.16 branch.