tiffload: add support for unlimited flag, requires libtiff 4.7.0+ #4322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default limit for cumulative allocation to 20MB, which is enough for hundreds of tags. Due to the way libtiff likes to re-allocate memory, an image with thousands of tags can quickly lead to fragmentation.
|
Great! Let's leave the 20mb for now, we can always tune this later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a default limit of 20MB for total maximum ("cumulated") memory allocation during tag processing, which should be enough for hundreds if not thousands of tags. I could easily be persuaded to reduce this default limit.
Given libtiff is rather over-zealous in the number of times it reallocates memory, an image containing many thousands of tags can quickly lead to fragmentation. Attempting to process the <1MB sample image at https://issues.oss-fuzz.com/issues/42531230 with this memory limitation in place still results in an RSS of ~1GB (the OSS Fuzz issue should auto-close after this PR is merged).
Builds on #4313 and implements #3892 for inclusion in 8.17.