colour: add support for auto-selecting the rendering intent #4366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Via the `VIPS_INTENT_AUTO` enum value. Resolves: libvips#3475.
kleisauke
commented
Jan 28, 2025
libvips/include/vips/colour.h
Outdated
| */ | ||
| typedef enum { | ||
| VIPS_INTENT_PERCEPTUAL = 0, | ||
| VIPS_INTENT_RELATIVE, | ||
| VIPS_INTENT_SATURATION, | ||
| VIPS_INTENT_ABSOLUTE, | ||
| VIPS_INTENT_AUTO, |
There was a problem hiding this comment.
Note: we cannot define VIPS_INTENT_AUTO as -1 because it would conflict with the return code of vips_enum_from_nick(). Therefore, all supported enum values must always be greater than or equal to 0.
jcupitt
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Via the
VIPS_INTENT_AUTOenum value.Resolves: #3475.