Skip to content

add matrixmultiply #4371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 1, 2025
Merged

add matrixmultiply #4371

merged 5 commits into from
Feb 1, 2025

Conversation

jcupitt
Copy link
Member

@jcupitt jcupitt commented Jan 31, 2025

needed for nip4 compat mode

needed for nip4 compat mode
matrixload is_a could fail to detect files like this:

```
2 2
0 0
1 1
```

The header parser was not stopping at EOL and thought that this file had scale
0, which it would then reject.
If the measurements filled the entire x range, we were not writing the
final value.

For example:

```
2 2
0 0
1 1
```

```
$ vips invertlut linear.mat x2.v
$ vips getpoint x2.v 255 0
-nan
```

With this PR you get 1, as expected.
@kleisauke
Copy link
Member

FWIW, the changes from PR #4372 and #4373 are also present in https://github.com/libvips/libvips/pull/4371/files for some reason. However, when viewing the diff at https://github.com/libvips/libvips/compare/add-matrixmultiply, these changes are not included.

(I assume this is a temporary glitch in GitHub that likely occurs when a PR includes merge commits that are not present in the master branch at the time of pushing to the PR's target branch)

@jcupitt
Copy link
Member Author

jcupitt commented Feb 1, 2025

Yes, I was puzzled by that. I suppose github was confused. Thanks for the review!

@jcupitt jcupitt merged commit b9e3074 into master Feb 1, 2025
13 checks passed
@jcupitt jcupitt deleted the add-matrixmultiply branch February 1, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants