heifload: ensure unlimited flag removes all security limits where possible #4398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requires libheif v1.19.0+
5 tasks
|
I think this is still problematic to do, see: #4266 (comment). |
|
... it would probably(?) be fine if you relocate this block above the |
|
Ah, I thought this change felt familiar, I'd forgotten about your previous attempt. I think I'll try to re-work this to only remove the memory allocation limit when |
|
PR #4399 should address that issue, so it's no longer a concern. |
kleisauke
approved these changes
Feb 21, 2025
Co-authored-by: Kleis Auke Wolthuizen <github@kleisauke.nl>
Open
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libheif v1.19.0 added new
heif_get_disabled_security_limitsAPI to remove all security limits.I discovered this whilst investigating lovell/sharp#4335 and removing all limits appears to provide a solution to it.