Skip to content

test: reduce severity of gifsave_timeout #4407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

kleisauke
Copy link
Member

On my AMD Ryzen 9 7900 workstation, the gifsave_timeout test consistently fails with:

$ meson test -C build --print-errorlogs
...
 8/12 gifsave_timeout          FAIL             2.46s   exit status 1
――― ✀ ―――
expected error return from vips_gifsave_buffer()
――――――――――

I suspect the image gets quantized/remapped within 2 seconds, so we can't guarantee that it always returns an error. The best we could do is g_assert(is_killed), which is a no-op in release builds.

Targets the 8.16 branch.

Copy link
Member

@lovell lovell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alas, further evidence that timeout-based testing is hard 🤣

@jcupitt jcupitt merged commit abcb97c into libvips:8.16 Mar 5, 2025
6 checks passed
@kleisauke kleisauke deleted the 8.16-reduce-timeout-test-severity branch March 5, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants