heifload: improve detection of seek beyond EOF #4424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcbc672 to
d2416db
Compare
|
Oh nice. Does this stop the annoying bad seeks errors we were getting? |
|
Not sure, perhaps we should check the return value of |
|
I'm wondering why libheif leaves the buffer/file/stream in this state. Seeking to
AFAIK, the last occurrence of those bad seek errors was fixed via PR #1921. I also haven't seen such errors from "the wild", at least not in the past seven days (since our log data isn't retained any longer). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures we check both the
old_positionandresultfor a possible error when seeking.Fixes https://issues.oss-fuzz.com/issues/404288018