Skip to content

Private threadpool #4430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 26, 2025
Merged

Private threadpool #4430

merged 3 commits into from
Mar 26, 2025

Conversation

jcupitt
Copy link
Member

@jcupitt jcupitt commented Mar 22, 2025

In the old model, there was a single rendering thread that moved between
the active sink_screen tasks by priority. If a thumbnail and a main
image window both needed updating, the thumbnail render (which can take
a long time since it is effectively single-threaded) could block
all high-priority updates.

This PR adds private threadpools for low priority vips_sink_screen()
rendering tasks. Now all thumbnails will update in the background as
single-threaded tasks, and will not block foreground updates.

jcupitt added 2 commits March 22, 2025 12:13
In the old model, there was a single rendering thread that moved between
the active sink_screen tasks by priority. If a thumbnail and a main
image window both needed updating, the thumbnail render (which can take
a long time since it is effectively single-threaded) could block
all high-priority updates.

This PR adds private threadpools for low priority vips_sink_screen()
rendering tasks. Now all thumbnails will update in the background as
single-threaded tasks, and will not block foreground updates.
@jcupitt jcupitt merged commit 881c4ca into master Mar 26, 2025
12 checks passed
@jcupitt jcupitt deleted the private-threadpool branch March 26, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants