Skip to content

Add jp2kload oneshot #4432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 23, 2025
Merged

Add jp2kload oneshot #4432

merged 3 commits into from
Mar 23, 2025

Conversation

jcupitt
Copy link
Member

@jcupitt jcupitt commented Mar 22, 2025

Some versions of openjpeg can fail to decode some tiled jpeg2000 images.

This PR adds a oneshot flag that flips jp2kload into "one shot" mode, ie. entire frames are loaded in one call, rather than a tile at a time.

This will use a lot more memory, and is usually slower, but it will make it possible to load files that otherwise could not be loaded.

closes #4205

@jcupitt
Copy link
Member Author

jcupitt commented Mar 22, 2025

Any thoughts on the name? oneshot might not be obvious.

@lovell
Copy link
Member

lovell commented Mar 22, 2025

Any thoughts on the name? oneshot might not be obvious.

Using https://xkcd.com/2254/ as inspiration how about "long haul"? 😜

@jcupitt
Copy link
Member Author

jcupitt commented Mar 22, 2025

hehe I think "oneshot" is a bit clearer

@jcupitt jcupitt merged commit cc4d147 into master Mar 23, 2025
13 checks passed
@jcupitt jcupitt deleted the add-jp2kload-oneshot branch March 23, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jp2kload: Invalid tile part index error on some JPEG 2000 files
2 participants