test and fix SAVEABLE #4495
Draft
test and fix SAVEABLE #4495
+246
−250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vips__foreign_convert_saveable() doesn't seem to work for all image types, start testing it more carefully. test_matrix tests matrixsave, which uses SAVEABLE_MONO ... test conversion of all image types
|
Sample bug in master from these problems -- RGB to mono works OK: So the It fails for RGBA. The saveable system needs simplifying and testing more carefully. |
a bit saner ... and deprecate VipsSaveable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vips__foreign_convert_saveable()doesn't seem to work for all image types, start testing it more carefully.test_matrixtests matrixsave, which usesSAVEABLE_MONO... test conversion of all image types.