fix an off by one error in rank #4610
Merged
+39
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
only there for three years sigh see #4609
jcupitt
commented
Jul 16, 2025
| */ | ||
| const int next = bands * rank->width; |
There was a problem hiding this comment.
this is the fix, it was bands * (rank->width - 1)
|
I reformatted to our more modern style, which make the fix hard to spot, but see the comment above. The error only really shows when running large rank filters on binary images, so maybe the three year discovery time is not so bad. I checked |
I'd left the demand hint for rank as smalltile from some debugging. I've set the whole of morphology to sequential mode, which should be safe, cf. the convolution base class.
|
Was |
kleisauke
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
only there for three years sigh
see #4609