Skip to content

Allow static linking on Windows #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 23, 2022

Conversation

talisein
Copy link
Contributor

I'm not sure why the static build was disabled on Windows... but it seems to work now at least.

  • Sets the missing define in libxml++config.h
  • Add libxml2 wrap, but continue to use the older library logic and only fallback to the wrap when we have to
  • add a workflow to build a static windows library. Here's a link to a passing run.

@kjellahl
Copy link
Collaborator

@talisein Is there a good reason your libxml2.wrap file downloads a released version
of libxml2? Other wrap files download the latest version from the git repo. See e.g.
https://gitlab.gnome.org/GNOME/gtkmm/-/tree/master/subprojects

@fanc999 Can you have a look at this PR, please.

@talisein
Copy link
Contributor Author

There's still no meson.build in libxml2 but it seems like someone is starting: https://gitlab.gnome.org/GNOME/libxml2/-/issues/328

@fanc999
Copy link
Collaborator

fanc999 commented Jun 17, 2022

Hi @kjellahl,

Sorry for the delay, I think other than the comment I had I think we are fine with this. I'm not a big fan of static builds, but I think otherwise things seemed to be fine with me.


Hi @talisein,

I think the other alternative to use the latest libxml2 version is to use the CMake method, since libxml2 does have a CMake build system.1 Maybe we want to split up this PR into 2, one for the static builds of libxml++, and the other for adding a fallback for libxml2.


With blessings, and cheers!

@kjellahl
Copy link
Collaborator

Maybe we want to split up this PR into 2, one for the static builds of libxml++, and the other for adding a fallback for libxml2.

@talisein Yes, it would be fine to split this up. At least separate commits
for enabling static builds and for having libxml2 as a subproject. They are
two unrelated features, aren't they?

@talisein
Copy link
Contributor Author

talisein commented Jun 17, 2022

Sure I'll split it up. Its there for the convenience of the github CICD workflow.

@talisein
Copy link
Contributor Author

I've split this PR up:

Once those two merge I'll open a PR to add the windows workflow

@fanc999
Copy link
Collaborator

fanc999 commented Jun 23, 2022

Hi @talisein,

Thanks, I think this PR looks fine to me at this point.

@kjellahl kjellahl merged commit 5ca94a5 into libxmlplusplus:master Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants