I don’t understand the new macro changes

Hi @neheb,

The thing is, we want to differentiate between Visual Studio builds and MinGW builds where it is necessary, because we need to export the whole xmlpp::exception class on MinGW so that the vtable of that class gets exported but we don't want to export the whole xmlpp::exception class on Visual Studio but instead export the members individually so that we can avoid ABI issues (note that Visual Studio export a class's vtable by default). Do things work for you?

Adding both dllexport and visibility on the same define is weird. They do the same thing on mingw.

Hi @neheb,

So, does the update fix your problem? I can always drop dllexport or visibility if things at this point did work for you (merely doing what is done in GLib).

The cross compiler in MinGW can build libxml++ with this fix, both with and without
__attribute__((visibility("default"))) in LIBXMLPP_VISIBILITY_DEFAULT.
If you decide to drop __attribute__((visibility("default"))), LIBXMLPP_VISIBILITY_DEFAULT
would of course be a strange name.

I've installed wine64 now. The ninja test executes all the example programs.

Please merge, unless @neheb has a better idea.

Hi,

Thanks for the ack (I decided to drop the __declspec(dllexport) for the visibility macro)!

Yesterday I tested

#define LIBXMLPP_VISIBILITY_DEFAULT __declspec(dllexport) __attribute__((visibility("default")))

and

#define LIBXMLPP_VISIBILITY_DEFAULT __declspec(dllexport)

Now you've chosen

#define LIBXMLPP_VISIBILITY_DEFAULT __attribute__((visibility("default")))

That does not work with the MinGW compiler.

The gcc manual says in the description of __attribute__((dllexport)) on Windows:

You can use __declspec(dllexport) as a synonym for __attribute__((dllexport)) for compatibility with other compilers.
On systems that support the visibility attribute, this attribute also implies “default” visibility.

__declspec(dllexport) seems to imply more than just default visibility.

Oh, sorry...

I will fix that in a bit, when I get my hands on my computer when I get back home.

Sorry about that

Okay now.