headers: Drop LIBXMLPP_API from 'friend' members #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They aren't really necessary and can raise warnings on Windows MinGW builds unless their locations were exchanged with 'class' or 'struct', but doing so is not liked by Visual Studio.
|
No warnings from the MinGW compiler with this fix. Please merge.
I would be surprised if such modifications of |
|
Hi, Thanks for the ack. Here goes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This drops the
LIBXMLPP_APIfrom thefriend classorfriend structmembers of classes, so that we can eliminate warnings on MinGW. The other alternative is to handle these classes like what we did in MR #46, since class members are exported individually rather than exported as a whole, if we want to be very very sure about the ABI stability.With blessings, thank you!