Skip to content

Meson: Cleanup and fix libxml2 dep search (for libxml++-5-0) #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

fanc999-1
Copy link
Contributor

@fanc999-1 fanc999-1 commented Jul 5, 2023

Hi,

This is the libxml++-5-0 version of #53.

With blessings, thank you!

Use CMake to help us find libxml2, in addition to using pkg-config, as
CMake actually looks up libxml2 for us using the headers in %INCLUDE%
and the libraries in %LIB% in a more comprehensive way, so we don't need
to reinvent the wheel.

Since we use Meson 0.60.0 or later, we can use the CMake libxml2
dependency name together with libxml-2.0.pc to find libxml2 in one
single call.

Also update the libxml2 CMake subproject by using CMake to find ICU and
liblzma in the same manner, and ensure that we have the correct
libxml2 .lib in the resulting pkg-config file for libxml++.
@kjellahl kjellahl merged commit 123563c into libxmlplusplus:libxml++-5-0 Jul 5, 2023
@fanc999-1 fanc999-1 deleted the meson-cleanup-msvc-5-0 branch July 6, 2023 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants