Skip to content

Meson build: Use libxml2 meson build as fallback #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

talisein
Copy link
Contributor

@talisein talisein commented Jun 6, 2024

Fixes #67

@talisein
Copy link
Contributor Author

talisein commented Jun 6, 2024

@fanc999-1 Can you take a look at this? In particular, I don't know what effect LIBXML2_LIB_NO_PKGCONFIG has in pkgconfig. In this PR, since CMake is no longer used for subproject builds I'm not sure this is needed. But maybe in the case where libxml2 was available from CMake and not from the subproject the variable should still be set? But I'm not sure what xml2_dep.type_name() is going to be in that scenario.

@talisein
Copy link
Contributor Author

talisein commented Jun 8, 2024

I added a commit to set LIBXML2_LIB_NO_PKGCONFIG when not pkgconfig or internal which should be a little closer to the way it was before.

@kjellahl kjellahl merged commit 1a34aa2 into libxmlplusplus:master Jun 10, 2024
@kjellahl
Copy link
Collaborator

I've merged this PR. Chun-wei Fan can comment afterwards, if he wants to.
But I'm not sure he gets our messages. Usually he replies quickly, but sometimes
he does not get messages sent via GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows meson build has undefined variable problems
2 participants