FEAT: Add support for additional types #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@linkdotnet I have added a POC. Can you please review this whenever you get a change and let me know what you think about it. Thanks 👍 |
linkdotnet
reviewed
Aug 22, 2023
linkdotnet
approved these changes
Aug 22, 2023
|
Can you also add an entry to the |
Added an entry to the |
linkdotnet
reviewed
Aug 23, 2023
|
LGTM! Is there anything open from your side, or can I merge that into the main branch? |
|
This can be merged and thanks for the detailed review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code changes comes from the discussion under #1 (comment)
What is changed?
What didn't work
My initial thought process while approaching this change was to leverage generics. But I made a mistake of thinking that generics support in Golang is equivalent to that of other programming languages. With Go's generics support, something such as below is not possible
More details: https://www.reddit.com/r/golang/comments/tvfbow/the_fact_that_methods_are_not_allowed_to_have/
Ok. So let's try another approach. Let's just create multiple
Appendmethods with different types. Good old method overloading. Ehhh. Golang does not even supports that in a clean manner. More details: https://stackoverflow.com/a/6987002/3938227What worked
Adding separate methods for each type does the job. Though it is not a clean abstraction as that of other programming languages such as Java(https://docs.oracle.com/javase/8/docs/api/java/lang/StringBuilder.html), it gets the job done.
NOTE
This is more of a POC. If this looks good, I can extend this PR to support the remaining types as described under the above API spec of Java's StringBuilder implementation