no nonlinearity in z #149
Merged
no nonlinearity in z #149
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -174,7 +174,7 @@ be computed with : | |||
|
|
|||
| .. math:: | |||
|
|
|||
| z = \sigma(W x_t + U h_{t-1} + b) | |||
| z = W x_t + U h_{t-1} + b | |||
There was a problem hiding this comment.
Can you double check that the code do that? I think so, but I could have looked at the wrong place in the code.
There was a problem hiding this comment.
The code for computing z looks like this:
preact = tensor.dot(h_, tparams[_p(prefix, 'U')])
preact += x_
https://github.com/lisa-lab/DeepLearningTutorials/blob/master/code/lstm.py#L175-L176
|
thanks |
taneishi
pushed a commit
to taneishi/DBN
that referenced
this pull request
Nov 28, 2019
no nonlinearity in z
taneishi
pushed a commit
to taneishi/DBN
that referenced
this pull request
Feb 13, 2020
no nonlinearity in z Former-commit-id: ea169ec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
z is a pre-activation, and \sigma should not be there. @hongkunyoo