Clarify difference between modern conv2d and original LeNet #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| The result sums all the convolved input feature maps with the corresponding | ||
| kernel. As opposed to some of the earlier works that used to select only | ||
| some of the input feature maps. | ||
|
|
There was a problem hiding this comment.
"in majority" => "in the majority"
"of of" => "of"
"library codes" => "implementations" ?
"is slightly different than" => "differs slightly from"
Starting at "In modern conv2d" until the end, it's not really obvious to me what you mean. This would probably benefit from being rephrased. There are a few typos and errors too, but I'll wait since this will probably be rewritten anyway.
|
I'm not sure which are you referring to as "one" and "others" |
|
You list 3 items, suggesting they are different but you only explain the characteristics of the 2 first items and not the third so the reader doesn't know how it differs from the 2 previous items. |
|
I tried to clarify it a bit further. |
lamblin
added a commit
that referenced
this pull request
Jul 6, 2015
Clarify difference between modern conv2d and original LeNet
taneishi
pushed a commit
to taneishi/DBN
that referenced
this pull request
Nov 28, 2019
Clarify difference between modern conv2d and original LeNet
taneishi
pushed a commit
to taneishi/DBN
that referenced
this pull request
Feb 13, 2020
Clarify difference between modern conv2d and original LeNet Former-commit-id: 656077a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #78