Allow building with Clang using MSVC ABI #418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The official LLVM build of Clang is using the MSVC ABI, and if you are using clang.exe and not clang-cl.exe you get the GNU command line interface. CMake would not set the MSVC variable, but the CMAKE_CXX_SIMULATE_ID as "MSVC". Since clang.exe is targeting the MSVC ABI it needs the build support the MSVC has.
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The official LLVM build of Clang is using the MSVC ABI, and if you are using clang.exe and not clang-cl.exe you get the GNU command line interface.
CMake would not set the MSVC variable, but the CMAKE_CXX_SIMULATE_ID as "MSVC". Since clang.exe is targeting the MSVC ABI it needs the build support the MSVC has.