Skip to content
This repository was archived by the owner on Aug 31, 2021. It is now read-only.

engine: WIP for special-casing specific syntax. #2992

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

runrevmark
Copy link
Contributor

Currently:

put x into VARIABLE
put x into byte y of VARIABLE

Currently:

put x into VARIABLE
put x into byte y of VARIABLE
@peter-b
Copy link
Contributor

peter-b commented Oct 5, 2015

@runrevmark Might be better to put the byte special case code into a separate function -- it'll keep the exec_ctxt() implementation easier to read...?

@runrevmark
Copy link
Contributor Author

@peter-b: Yes - I was thinking of putting all the special cases into a peephole.cpp file or similar... I don't think we need that many to being with:

put X into VAR
put X into byte/char/codepoint/codeunit Y of VAR
put byte/char/codepoint/codeunit X of VAR1 into byte/char/codepoint/codeunit Y of VAR2

add X to VAR
subtract X from VAR
multiply X by VAR
divide X by VAR

The 'put X into VAR' should have an effect on all code (a bit like my 'get' patch); the others should have a significant impact on image processing loops.

@peter-b
Copy link
Contributor

peter-b commented Oct 5, 2015

@runrevmark Sounds good to me 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants