Skip to content
This repository was archived by the owner on Aug 31, 2021. It is now read-only.

[[ Bug 20286 ]] Add tool property of image - EXPERIMENT #5829

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

runrevmark
Copy link
Contributor

This patch is an experiment to see how well a tool property of images
would work.

As posed, it is quite straight-forward, but there are some details to
pin down. For example, when should the image's tool be used? How should
the IDE use it in edit mode - should it?

At the moment tool property of an image can only be 'pencil' and that
overrides any global tool other than 'help'. This means that if an
image has its tool property set in the IDE, in both browse and edit
mode the image is editable.

Also, cursor changes don't currently occur which makes it even more
confusing. (Although this is just an experiment - so I've not poked
too deeply!)

This patch is an experiment to see how well a tool property of images
would work.

As posed, it is quite straight-forward, but there are some details to
pin down. For example, when should the image's tool be used? How should
the IDE use it in edit mode - should it?

At the moment tool property of an image can only be 'pencil' and that
overrides any global tool other than 'help'. This means that if an
image has its tool property set in the IDE, in both browse and edit
mode the image is editable.

Also, cursor changes don't currently occur which makes it even more
confusing. (Although this is just an experiment - so I've not poked
too deeply!)
@runrevmark
Copy link
Contributor Author

There's another question here over the paint-specific tool state... Should this be replicated at the image level? Or is using the global properties okay (at least in the first instance) - e.g. the brush etc.

@montegoulding
Copy link
Member

montegoulding commented Aug 23, 2017

I wonder if it might be better to change the behavior of those tools by adding an editImage stack property that if empty causes the automatic creation behavior we have now. If an editImage is set then the tools only work within the image visible rect on the target image. Do you want multiple images with edit tools...

@runrevmark
Copy link
Contributor Author

That doesn't solve the 'editing an image in a group' problem; nor the 'if in pencil tool, I can edit any top-level non-referenced image' problem...

@montegoulding
Copy link
Member

Hmm... Doesn't it solve both those?

@runrevmark
Copy link
Contributor Author

Ah - sorry - I misunderstood - so editImage would be an image reference?

@montegoulding
Copy link
Member

Yep

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants