This repository was archived by the owner on Aug 31, 2021. It is now read-only.
[[ Bug 20286 ]] Add tool property of image - EXPERIMENT #5829
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is an experiment to see how well a tool property of images
would work.
As posed, it is quite straight-forward, but there are some details to
pin down. For example, when should the image's tool be used? How should
the IDE use it in edit mode - should it?
At the moment tool property of an image can only be 'pencil' and that
overrides any global tool other than 'help'. This means that if an
image has its tool property set in the IDE, in both browse and edit
mode the image is editable.
Also, cursor changes don't currently occur which makes it even more
confusing. (Although this is just an experiment - so I've not poked
too deeply!)