Skip to content
This repository was archived by the owner on Aug 31, 2021. It is now read-only.

[Bugfix 15614] Replace URLEncode example #6446

Merged
merged 4 commits into from
Apr 10, 2018

Conversation

livecodealice
Copy link

Replaced example in URLEncode with one that only encodes the part of the URL that ought to be encoded.

livecodesam added 2 commits March 22, 2018 11:17
Substituted an example with one that encodes only the part of the URL that ought to be encoded.
@montegoulding
Copy link
Member

@livecodesam while you are changing this doc I'm wondering if you could add a discussion about the fact the function does not conform to RFC3986 and perhaps add the following example code for how to use it to conform:

function urlEncodeRFC pString
   if pString is strictly a string then
      put textEncode(pString,"utf8") into pString
   end if
   put urlEncode(pString) into pString
   replace "+" with "%20" in pString
   return pString
end urlEncodeRFC

@livecodepanos livecodepanos changed the base branch from develop-8.2 to develop-9.0 March 23, 2018 13:57
@montegoulding
Copy link
Member

In order to make travis test against develop-9.0 we need to touch the last commit... not sure how to do that via the web interface though @livecodesam

@livecodepanos
Copy link
Contributor

livecodepanos commented Mar 28, 2018

@livecodesam @montegoulding What about adding a local tGoodURL in the example and commiting it? I guess the new commit will force Travis to make the checks against the new base branch (develop-9.0)

@livecodepanos
Copy link
Contributor

@livecode-vulcan review ok cca5cf0

@livecode-vulcan
Copy link
Contributor

💙 review by @livecodepanos ok cca5cf0

livecode-vulcan added a commit that referenced this pull request Apr 6, 2018
[Bugfix 15614] Replace URLEncode example

Replaced example in URLEncode with one that only encodes the part of the URL that ought to be encoded.
@livecode-vulcan
Copy link
Contributor

😎 test success cca5cf0

  • try-community-armv6-android-api8: success
  • try-community-armv6-android-api9: success
  • try-community-js-emscripten-sdk1.35: success
  • try-community-universal-ios-iphoneos11.2: success
  • try-community-universal-ios-iphonesimulator11.2: success
  • try-community-universal-mac-macosx10.6: success
  • try-community-universal-mac-macosx10.9: success
  • try-community-x86-linux-debian7: success
  • try-community-x86-linux-debian8: success
  • try-community-x86_64-linux-debian7: success
  • try-community-x86_64-linux-debian8: success
  • try-community-x86-win32: success
  • try-community-x86_64-win32: success

@livecodepanos livecodepanos merged commit 329ccf0 into livecode:develop-9.0 Apr 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants