[[ WindowsCI ]] Add travis configuration for windows #7076

livecodeali · 2019-05-31T07:44:11Z

This patch adds travis configuration for windows.

A number of tweaks have been made to the source code, but they are mostly optional and controlled by environment variables so they do not affect other builds. One minor change is that make.cmd is now expected to be run from the base folder rather than from within the build-win-<arch> folder. This is because some environments appear to have a problem executing cmd.exe /C ../make.cmd and are much happier with cmd.exe /C make.cmd

On Travis we use a chocolatey-installed winflexbison package to provide flex and bison dependencies - they are then named win_flex and win_bison, so control of whether these are used or not in the yacc step has been implemented via an environment variable USE_WINFLEXBISON.

For an as-yet unidentified reason, the generation of lcidlc support files fails in Travis' windows build environment, so we skip it. An environment variable SKIP_LCIDLC is used to handle this.

The current configure.bat script requires user input to run, so this PR tweaks the script to remove that requirement if the build is running on Travis.

A python script has been added which twiddles the appropriate bit of a windows executable to turn it into a console application - this is needed to be able to run tests using the standalone engine.

Finally a whole bunch of tests have been fixed, tweaked, skipped or removed in order to get everything passing.

livecodeali · 2019-06-03T17:13:02Z

🍾 🍾 🍾 !

runrevmark · 2019-06-03T17:17:37Z

tests/lcs/core/array/combine.livecodescript

@@ -35,7 +35,12 @@ on TestCombineStrings
   sort lines of tArray by item 1 of each
   sort lines of tUncombinedData by item 1 of each

-   TestAssert "Combine strings", tUncombinedData is tArray
+   if the platform is "win32" then


I'm not clear why these are broken on win32 and not on other platforms - unless the input data is being generated differently... My concern is that the test is actually broken on all platforms, and it is just serendipitous that it is okay on Linux/macOS...

As discussed offline, I'm inclined to mark this test as broken for all platforms.

runrevmark · 2019-06-03T17:17:48Z

tests/lcs/core/array/combine.livecodescript

-
-   TestAssert "Combine numbers and strings", tUncombinedData is tArray
+
+   if the platform is "win32" then


Same as with the above...

montegoulding · 2019-06-03T23:04:59Z

@livecodeali do you have a copy of the lcidlc error? If we ever want to do https://quality.livecode.com/show_bug.cgi?id=22059 then we will need to sort it.

livecodeali · 2019-06-04T05:22:58Z

https://api.travis-ci.org/v3/job/540785162/log.txt

(ClCompile target) -> 
  c:\users\travis\build\livecode\livecode\build-win-x86_64\livecode\debug\obj\global_intermediate\lcidlc\encodedjavasupport.c(1): error C2059: syntax error: '.' [C:\Users\travis\build\livecode\livecode\build-win-x86_64\livecode\lcidlc\lcidlc.vcxproj]
  c:\users\travis\build\livecode\livecode\build-win-x86_64\livecode\debug\obj\global_intermediate\lcidlc\encodedjavasupport.c(1): error C2017: illegal escape sequence [C:\Users\travis\build\livecode\livecode\build-win-x86_64\livecode\lcidlc\lcidlc.vcxproj]
  c:\users\travis\build\livecode\livecode\build-win-x86_64\livecode\debug\obj\global_intermediate\lcidlc\encodedsupport.c(1): error C2059: syntax error: '.' [C:\Users\travis\build\livecode\livecode\build-win-x86_64\livecode\lcidlc\lcidlc.vcxproj]
  c:\users\travis\build\livecode\livecode\build-win-x86_64\livecode\debug\obj\global_intermediate\lcidlc\encodedsupport.c(1): error C2017: illegal escape sequence [C:\Users\travis\build\livecode\livecode\build-win-x86_64\livecode\lcidlc\lcidlc.vcxproj]

It looks like it's not generating the support files correctly for some reason...

montegoulding · 2019-06-04T05:29:56Z

Hmm... Ok. Would be interesting to see the files. Perhaps a Perl version issue???

livecodeali · 2019-06-04T06:47:02Z

Yeah that was my vague suspicion

livecodeali · 2019-06-05T21:20:09Z

@runrevmark OK, been less lazy with the tests and fixed a bunch (in particular the widget ones which seems to be an issue with capturing the error dialog using wait for messages - perhaps there were additional messages happening on windows?

peter-b · 2019-06-07T14:14:52Z

@livecodeali Congratulations! Awesome work getting the tests to run on Windows. 👏 👏

livecodeali · 2019-06-12T23:01:27Z

@peter-b Heh, thanks... it's been quite a long road. I've had them running via buildbot before, but not in a way that can be merged. However that did help as I'd fixed a lot of tests already for this!

This patch tweaks the various path calculations in test makefiles (and the common makefile) to support testing windows executables

This patch adds a python script which twiddles the appropriate bit in a windows executable to make it a console application. Console applications do not open a separate console window when invoked on the command line - the command prompt only returns when the executable process finishes. This is the necessary behavior for the standalone engine when running tests.

This patch fixes, removes or skips a number of tests that fail or are no longer correct on windows.

This patch allows the use of flex and bison which have been installed via the chocolatey package winflexbison as the method of installing via cygwin does not work on Travis' windows containers. Use of win_flex and win_bison can be controlled with an environment variable `USE_WINFLEXBISON`

This patch removes the need to run make.cmd from within the generated build folder.

This patch ensures that if we are running on Travis, the configure script does not pause for warnings as this requires user input and we want the build to continue even if there are warnings.

This patch adds a windows target to the travis configuration file. This build uses the chocolatey winflexbison package, skips building lcidlc and only runs LiveCode script based tests, and is restricted to extension and engine tests for now.

On Travis' windows container, the generation of lcidlc's support files fails and causes a compilation error. This patch adds a mechanism for skipping lcidlc builds.

livecodeali force-pushed the travis-ci-windows branch from 68964b5 to 9fc243c Compare May 31, 2019 07:55

livecodeali closed this May 31, 2019

livecodeali reopened this May 31, 2019

livecodeali force-pushed the travis-ci-windows branch from 9fc243c to 970ee5f Compare May 31, 2019 08:41

livecodeali added the WIP label May 31, 2019

livecodeali force-pushed the travis-ci-windows branch 5 times, most recently from eeeab38 to 2adf9c6 Compare June 3, 2019 13:35

livecodeali changed the title ~~Travis ci windows~~ [[ WindowsCI ]] Add travis configuration for windows Jun 3, 2019

livecodeali force-pushed the travis-ci-windows branch 2 times, most recently from c43071d to bde19da Compare June 3, 2019 13:46

livecodeali removed the WIP label Jun 3, 2019

livecodeali force-pushed the travis-ci-windows branch 4 times, most recently from 1d0dfad to 0a317e8 Compare June 3, 2019 15:35

livecodeali added this to the 9.5.0-dp-2 milestone Jun 3, 2019

runrevmark reviewed Jun 3, 2019

View reviewed changes

livecodeali force-pushed the travis-ci-windows branch 4 times, most recently from 7c7d452 to 9ce5dcf Compare June 5, 2019 16:44

livecodeali force-pushed the travis-ci-windows branch from 9ce5dcf to 8bdd56b Compare June 5, 2019 20:13

livecodeali force-pushed the travis-ci-windows branch 2 times, most recently from a4a0601 to 92e6844 Compare June 11, 2019 07:29

livecodeali force-pushed the travis-ci-windows branch from 92e6844 to 0bf7d78 Compare June 12, 2019 23:07

livecodepanos removed this from the 9.5.0-rc-1 milestone Sep 17, 2019

livecodeali added 8 commits April 30, 2020 16:27

[[ WindowsCI ]] Add windows support to test makefiles

1bc86b7

This patch tweaks the various path calculations in test makefiles (and the common makefile) to support testing windows executables

[[ WindowsCI ]] Fix tests for windows

e00ed5a

This patch fixes, removes or skips a number of tests that fail or are no longer correct on windows.

[[ WindowsCI ]] Allow make.cmd to be run from base folder

4294da9

This patch removes the need to run make.cmd from within the generated build folder.

[[ WindowsCI ]] Don't pause configure script on warning

70cb554

This patch ensures that if we are running on Travis, the configure script does not pause for warnings as this requires user input and we want the build to continue even if there are warnings.

[[ WindowsCI ]] Allow skipping of lcidlc

6ac5d00

On Travis' windows container, the generation of lcidlc's support files fails and causes a compilation error. This patch adds a mechanism for skipping lcidlc builds.

livecodeali force-pushed the travis-ci-windows branch from 0bf7d78 to 6ac5d00 Compare April 30, 2020 15:34

livecodeali closed this Apr 30, 2020

livecodeali mentioned this pull request Apr 30, 2020

[[ WindowsCI ]] Add travis configuration for windows #7344

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[[ WindowsCI ]] Add travis configuration for windows #7076

[[ WindowsCI ]] Add travis configuration for windows #7076

Uh oh!

livecodeali commented May 31, 2019 •

edited

Loading

Uh oh!

livecodeali commented Jun 3, 2019

Uh oh!

runrevmark Jun 3, 2019

Uh oh!

runrevmark Jun 5, 2019 •

edited

Loading

Uh oh!

runrevmark Jun 3, 2019

Uh oh!

runrevmark Jun 5, 2019

Uh oh!

montegoulding commented Jun 3, 2019

Uh oh!

livecodeali commented Jun 4, 2019

Uh oh!

montegoulding commented Jun 4, 2019

Uh oh!

livecodeali commented Jun 4, 2019

Uh oh!

livecodeali commented Jun 5, 2019

Uh oh!

peter-b commented Jun 7, 2019

Uh oh!

livecodeali commented Jun 12, 2019

Uh oh!

Uh oh!


		TestAssert "Combine numbers and strings", tUncombinedData is tArray

		if the platform is "win32" then

[[ WindowsCI ]] Add travis configuration for windows #7076

[[ WindowsCI ]] Add travis configuration for windows #7076

Uh oh!

Conversation

livecodeali commented May 31, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

livecodeali commented Jun 3, 2019

Uh oh!

runrevmark Jun 3, 2019

Choose a reason for hiding this comment

Uh oh!

runrevmark Jun 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

runrevmark Jun 3, 2019

Choose a reason for hiding this comment

Uh oh!

runrevmark Jun 5, 2019

Choose a reason for hiding this comment

Uh oh!

montegoulding commented Jun 3, 2019

Uh oh!

livecodeali commented Jun 4, 2019

Uh oh!

montegoulding commented Jun 4, 2019

Uh oh!

livecodeali commented Jun 4, 2019

Uh oh!

livecodeali commented Jun 5, 2019

Uh oh!

peter-b commented Jun 7, 2019

Uh oh!

livecodeali commented Jun 12, 2019

Uh oh!

Uh oh!

livecodeali commented May 31, 2019 •

edited

Loading

runrevmark Jun 5, 2019 •

edited

Loading