This repository was archived by the owner on Aug 31, 2021. It is now read-only.
[[ Bug 23193 ]] Ensure AppTrackingTransparency framework is included on iOS 14+ #7579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on iOS 14+ This patch ensures the AppTrackingTransparency framework is included if the version of the target_sdk is 14+ not only on simulator builds but also on device builds.
|
@livecode-vulcan review ok e203707 |
|
💙 review by @livecodeian ok e203707 |
livecode-vulcan
added a commit
that referenced
this pull request
Jun 9, 2021
[[ Bug 23193 ]] Ensure AppTrackingTransparency framework is included on iOS 14+ This patch ensures the AppTrackingTransparency framework is included if the version of the target_sdk is 14+ not only on simulator builds but also on device builds.
|
😞 test failure e203707
|
e203707 to
a04f7e6
Compare
a04f7e6 to
a42c7a2
Compare
|
The current version of this PR fails when building an iOS standalone with error: EDIT: This #7580 PR fixes this ^^ build error |
a42c7a2 to
32025a6
Compare
|
Removing WIP - this PR is ready for review now. |
|
@livecode-vulcan review ok 32025a6 |
|
💙 review by @livecodeian ok 32025a6 |
livecode-vulcan
added a commit
that referenced
this pull request
Jun 10, 2021
[[ Bug 23193 ]] Ensure AppTrackingTransparency framework is included on iOS 14+ This patch ensures the AppTrackingTransparency framework is included if the version of the target_sdk is 14+ not only on simulator builds but also on device builds.
|
😎 test success 32025a6
|
|
|
||
| read SDK_MAJORVERSION SDK_MINORVERSION <<<${SDK_NAME//[^0-9]/ } | ||
| read SDK_PLATFORM <<<${SDK_NAME//[0-9.]/ } | ||
|
|
||
| if [ "$LIVECODE_DEP_FILE" == "" ]; then |
There was a problem hiding this comment.
@livecodepanos sorry. Little late to the review. This change is not necessary and should be reverted because lclidl based externals have a different mechanism for conditional inclusion of frameworks
| DEPS=`cat "$SRCROOT/$PRODUCT_NAME.ios"` | ||
| read SDK_MAJORVERSION SDK_MINORVERSION <<<${SDK_NAME//[^0-9]/ } | ||
|
|
||
| if [[ $SDK_MAJORVERSION -ge 14 && "$PRODUCT_NAME" == "standalone" ]] ; then |
There was a problem hiding this comment.
@livecodepanos I think this means you need to add this file for each of the externals. Perhaps check if it's there and fallback?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch ensures the AppTrackingTransparency framework is included if the version of the target_sdk is 14+
not only on simulator builds but also on device builds.