Fixes deadlock on publish track #604
Conversation
During a publish track, if the room is leaved before the the track is published, we can't publish a track anymore. Let's abord the pending publish track on leave event and when the websocket is disconnected
🦋 Changeset detectedLatest commit: c3052ae The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
LGTM, can you add a changeset and run spotless? Instructions found here:
https://github.com/livekit/client-sdk-android/blob/main/CONTRIBUTING.md
Also, have you agreed to our CLA? Usually a bot checks for this, but seems like it didn't trigger?
|
Thanks for the approval. No I didn't have any link to sign the CLA. Is it possible to sign it manually ? |
|
|
|
@jeankruger looks like there was a hiccup with the settings on our end, try the link from the bot now. |
|
Thanks for your help, it's done. |
|
Thanks for the PR! |
|
Deadlock is still happening when you try to enable or disable a track. Here is how to reproduce it:
This is pretty bad because there is no way to clear the deadlock forcing an app restart to resolve the issue. |
|
@kasemj is this on 2.13.3? |
Yes unfortunately, on the latest version 2.13.3. I was hoping this PR fixed the issue but I guess it didn’t address this particular scenario. |
During a publish track, if the room is leaved before the the track is published, we can't publish a track anymore. Let's abord the pending publish track on leave event and when the websocket is disconnected