Skip to content

Conversation

marcbachmann
Copy link
Member

No description provided.

@marcbachmann marcbachmann force-pushed the remove-grunt branch 2 times, most recently from 5e459d8 to 456021d Compare February 19, 2017 23:29
@@ -1,3 +1,4 @@
$ = require('jquery')
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That might be a breaking change.
In the minified version the script is now using window.jQuery instead of window.$ like before.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I discussed that with @peyerluk. He agrees that this is fine to merge.
Every time $ is present, there's also a jQuery variable.
An exception might be sth like zepto. But we think nobody that uses this library actually uses sth like that.

@marcbachmann
Copy link
Member Author

oh, bower still exists. Sorry, but we're dropping support for that in here.
not worth a major release - sorry

@marcbachmann marcbachmann merged commit e328be7 into master Feb 20, 2017
@marcbachmann marcbachmann deleted the remove-grunt branch February 20, 2017 19:06
@livingdocs-automation
Copy link

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants