Skip to content

Commit 0c30a11

Browse files
refactor: remove Docs from the navbar (coder#16251)
Close coder#16247
1 parent 4872d14 commit 0c30a11

File tree

5 files changed

+0
-26
lines changed

5 files changed

+0
-26
lines changed

site/src/modules/dashboard/Navbar/MobileMenu.stories.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ const meta: Meta<typeof MobileMenu> = {
3939
},
4040
user: MockUser,
4141
supportLinks: MockSupportLinks,
42-
docsHref: "https://coder.com/docs",
4342
onSignOut: fn(),
4443
isDefaultOpen: true,
4544
canViewAuditLog: true,

site/src/modules/dashboard/Navbar/MobileMenu.tsx

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@ type MobileMenuProps = MobileMenuPermissions & {
4545
proxyContextValue?: ProxyContextValue;
4646
user?: TypesGen.User;
4747
supportLinks?: readonly TypesGen.LinkConfig[];
48-
docsHref: string;
4948
onSignOut: () => void;
5049
isDefaultOpen?: boolean; // Useful for storybook
5150
};
@@ -55,7 +54,6 @@ export const MobileMenu: FC<MobileMenuProps> = ({
5554
proxyContextValue,
5655
user,
5756
supportLinks,
58-
docsHref,
5957
onSignOut,
6058
...permissions
6159
}) => {
@@ -90,12 +88,6 @@ export const MobileMenu: FC<MobileMenuProps> = ({
9088
</>
9189
)}
9290
<DropdownMenuSeparator />
93-
<DropdownMenuItem asChild className={itemStyles.default}>
94-
<a href={docsHref} target="_blank" rel="noreferrer norefereer">
95-
Docs
96-
</a>
97-
</DropdownMenuItem>
98-
<DropdownMenuSeparator />
9991
<UserSettingsSub
10092
user={user}
10193
supportLinks={supportLinks}

site/src/modules/dashboard/Navbar/Navbar.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ export const Navbar: FC = () => {
3535
canViewHealth={canViewHealth}
3636
canViewAuditLog={canViewAuditLog}
3737
proxyContextValue={proxyContextValue}
38-
docsHref={appearance.docs_url}
3938
/>
4039
);
4140
};

site/src/modules/dashboard/Navbar/NavbarView.test.tsx

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ describe("NavbarView", () => {
2525
it("workspaces nav link has the correct href", async () => {
2626
renderWithAuth(
2727
<NavbarView
28-
docsHref="https://docs.coder.com"
2928
proxyContextValue={proxyContextValue}
3029
user={MockUser}
3130
onSignOut={noop}
@@ -43,7 +42,6 @@ describe("NavbarView", () => {
4342
it("templates nav link has the correct href", async () => {
4443
renderWithAuth(
4544
<NavbarView
46-
docsHref="https://docs.coder.com"
4745
proxyContextValue={proxyContextValue}
4846
user={MockUser}
4947
onSignOut={noop}
@@ -61,7 +59,6 @@ describe("NavbarView", () => {
6159
it("audit nav link has the correct href", async () => {
6260
renderWithAuth(
6361
<NavbarView
64-
docsHref="https://docs.coder.com"
6562
proxyContextValue={proxyContextValue}
6663
user={MockUser}
6764
onSignOut={noop}
@@ -80,7 +77,6 @@ describe("NavbarView", () => {
8077
it("deployment nav link has the correct href", async () => {
8178
renderWithAuth(
8279
<NavbarView
83-
docsHref="https://docs.coder.com"
8480
proxyContextValue={proxyContextValue}
8581
user={MockUser}
8682
onSignOut={noop}

site/src/modules/dashboard/Navbar/NavbarView.tsx

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ import { UserDropdown } from "./UserDropdown/UserDropdown";
1313
export interface NavbarViewProps {
1414
logo_url?: string;
1515
user?: TypesGen.User;
16-
docsHref: string;
1716
buildInfo?: TypesGen.BuildInfoResponse;
1817
supportLinks?: readonly TypesGen.LinkConfig[];
1918
onSignOut: () => void;
@@ -33,7 +32,6 @@ const linkStyles = {
3332
export const NavbarView: FC<NavbarViewProps> = ({
3433
user,
3534
logo_url,
36-
docsHref,
3735
buildInfo,
3836
supportLinks,
3937
onSignOut,
@@ -67,15 +65,6 @@ export const NavbarView: FC<NavbarViewProps> = ({
6765
canViewHealth={canViewHealth}
6866
/>
6967

70-
<a
71-
className={linkStyles.default}
72-
href={docsHref}
73-
target="_blank"
74-
rel="noreferrer"
75-
>
76-
Docs
77-
</a>
78-
7968
{user && (
8069
<UserDropdown
8170
user={user}
@@ -90,7 +79,6 @@ export const NavbarView: FC<NavbarViewProps> = ({
9079
proxyContextValue={proxyContextValue}
9180
user={user}
9281
supportLinks={supportLinks}
93-
docsHref={docsHref}
9482
onSignOut={onSignOut}
9583
canViewAuditLog={canViewAuditLog}
9684
canViewOrganizations={canViewOrganizations}

0 commit comments

Comments
 (0)