[libc] implement template functions for localtime #110363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
6e15b2f to
15a5bef
Compare
95ad2ec to
4e12c67
Compare
469939e to
47a3589
Compare
|
Instead of using |
petrhosek
reviewed
Oct 14, 2024
petrhosek
reviewed
Oct 15, 2024
5c51ae3 to
316e0a9
Compare
|
Even though this pull request is not yet finished, I thought it would be great to get a review since this pull request is getting quite big. There are some unit tests that are not working, and have been commented out. |
eca1d44 to
1456c67
Compare
petrhosek
reviewed
Dec 26, 2024
petrhosek
reviewed
Dec 26, 2024
2f14147 to
6a84f62
Compare
Consider marking this as a "draft" in the github UI. |
|
This is a large change and there are some aspects that will likely require more discussion, like what kind of TZ support we even want and how to do it, whether we could share the implementation with libc++, etc. This could be discussed either on Discourse or at the public LLVM-libc meeting (or both). In the meantime, I think the best path forward would be to split this change into multiple changes, with the first one being just an empty minimal implementation which could be merged while we're discussing the implementation details. |
Sure, I will mark this as a draft. |
7d246be to
88911f0
Compare
69835d8 to
2e11cb4
Compare
…ile" This reverts commit da8d1ff.
michaelrj-google
approved these changes
Sep 2, 2025
|
That would be great. Thank you for the reviews. |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/11/builds/23186 Here is the relevant piece of the build log for the reference |
michaelrj-google
added a commit
to michaelrj-google/llvm-project
that referenced
this pull request
Sep 3, 2025
The fuchsia builder was broken by llvm#110363 This patch disables localtime for aarch64 baremetal, which is the failing target. Context: https://lab.llvm.org/buildbot/#/builders/11/builds/23186
michaelrj-google
added a commit
that referenced
this pull request
Sep 3, 2025
The fuchsia builder was broken by #110363 This patch disables localtime for aarch64 baremetal, which is the failing target. Context: https://lab.llvm.org/buildbot/#/builders/11/builds/23186
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Sep 4, 2025
The fuchsia builder was broken by llvm/llvm-project#110363 This patch disables localtime for aarch64 baremetal, which is the failing target. Context: https://lab.llvm.org/buildbot/#/builders/11/builds/23186
ckoparkar
added a commit
to ckoparkar/llvm-project
that referenced
this pull request
Sep 4, 2025
* main: (1483 commits) [clang] fix error recovery for invalid nested name specifiers (llvm#156772) Revert "[lldb] Add count for errors of DWO files in statistics and combine DWO file count functions" (llvm#156777) AMDGPU: Add agpr variants of multi-data DS instructions (llvm#156420) [libc][NFC] disable localtime on aarch64/baremetal (llvm#156776) [win/asan] Improve SharedReAlloc with HEAP_REALLOC_IN_PLACE_ONLY. (llvm#132558) [LLDB] Make internal shell the default for running LLDB lit tests. (llvm#156729) [lldb][debugserver] Max response size for qSpeedTest (llvm#156099) [AMDGPU] Define 1024 VGPRs on gfx1250 (llvm#156765) [flang] Check for BIND(C) name conflicts with alternate entries (llvm#156563) [RISCV] Add exhausted_gprs_fprs test to calling-conv-half.ll. NFC (llvm#156586) [NFC] Remove trailing whitespaces from `clang/include/clang/Basic/AttrDocs.td` [lldb] Mark scripted frames as synthetic instead of artificial (llvm#153117) [docs] Refine some of the wording in the quality developer policy (llvm#156555) [MLIR] Apply clang-tidy fixes for readability-identifier-naming in TransformOps.cpp (NFC) [MLIR] Add LDBG() tracing to VectorTransferOpTransforms.cpp (NFC) [NFC] Apply clang-format to PPCInstrFutureMMA.td (llvm#156749) [libc] implement template functions for localtime (llvm#110363) [llvm-objcopy][COFF] Update .symidx values after stripping (llvm#153322) Add documentation on debugging LLVM. [lldb] Add count for errors of DWO files in statistics and combine DWO file count functions (llvm#155023) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation for template functions of localtime.
Update for this pull request: Implementation as been removed from this pull request and will be added to a new one. This is because this pull request is getting big. This pull request will only contain template functions in order to implement localtime.
Update: The implementation is available in https://github.com/zimirza/llvm-project/tree/localtime_implementation.