[llvm] add vt_gen target as a dependency of llvm/lib/Analysis #120661
Conversation
DroppedVariableStats.cpp includes `llvm/include/llvm/Analysis/DroppedVariableStats.h` through its header, which transitively requires `llvm/CodeGen/GenVT.inc` (which is what `vt_gen` depends on) through `llvm/include/llvm/CodeGenTypes/MachineValueType.h`
|
@llvm/pr-subscribers-llvm-analysis Author: None (h-vetinari) Changes
Based on my testing, this should address #107687, at least for the case where only llvm is being built. There may be further places in clang, mlir etc. that need to add CC @chapuni as author of 631bfdb Full diff: https://github.com/llvm/llvm-project/pull/120661.diff 1 Files Affected:
diff --git a/llvm/lib/Analysis/CMakeLists.txt b/llvm/lib/Analysis/CMakeLists.txt
index 0db5b80f336cb5..cf393850ec3e68 100644
--- a/llvm/lib/Analysis/CMakeLists.txt
+++ b/llvm/lib/Analysis/CMakeLists.txt
@@ -150,6 +150,7 @@ add_llvm_component_library(LLVMAnalysis
DEPENDS
intrinsics_gen
+ vt_gen
${MLDeps}
LINK_LIBS
|
Currently, it does.
Sorry, no idea about this, I'm just trying to fix a build failure because any TU that ends up including |
|
@h-vetinari Possibly it is an apparent fix "just works for you". |
|
I think the correct fix here would be to revert #120502. |
|
Closing this as solved elsewhere |
DroppedVariableStats.cppincludesllvm/include/llvm/Analysis/DroppedVariableStats.hthrough its header, which transitively requiresllvm/CodeGen/GenVT.inc(which is whatvt_gendepends on) throughllvm/include/llvm/CodeGenTypes/MachineValueType.hBased on my testing, this should address #107687, at least for the case where only llvm is being built. There may be further places in clang, mlir etc. that need to add
DEPENDS vt_genfor usingllvm/include/llvm/CodeGenTypes/MachineValueType.hCC @chapuni as author of 631bfdb