[OpenMP] Allow Fortran tests #150722
Open
[OpenMP] Allow Fortran tests #150722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37c2993 to
70dbb33
Compare
mjklemm
reviewed
Aug 28, 2025
|
The Flang (and Clang) test folder does not contain end2end tests, and cannot as it requires running the executable which is not necessarily possible on the build machine (e.g. building a cross-compiler). Tests of Flang/Clang as unit/regression tests has the form of compiling the program to LLVM-IR, and using FileCheck to verify its output. This is done as well, but those do not make it easy to see whether the output is actually correct. And so it happened that code passed reviews that was obviously broken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to existing C/C++ tests, add Fortran-based tests. Fortran tests will only run if a Fortran compiler is found. The first test is for the unroll construct added in #144785.