[LLVM][IR] Switch from manual pointer incrementation to function in Lexer #152103
Conversation
|
Ping @nikic as I haven't found a IR specific maintainer |
There was a problem hiding this comment.
Can you please explain the motivation for making everything go through getNextChar()? The discourse thread mentions that this is somehow LSP related, but it's not obvious to me how.
Using getNextChar() instead of incrementing CurPtr seems reasonable enough, I'm more curious about things like advancePositionTo which now do a byte-wise advance instead of the obvious thing.
|
For the LSP, the lexer needs to know the current line:column location of the tokens. That's why everything goes through the |
|
gentle ping @nikic |
The IR Lexer has a
getNextChar()function implemented. But it is used only once, on other places the pointer pointing to the current position in the lexed string (CurPtr) is incremented manually, this can lead to some OOB errors (see #151556 and Discourse thread).To mitigate the issue, this PR changes the
getNextChar()to be more straight forward, changes all manual pointer increments togetNextChar()or adds checks, so that no OOB occurs.Two helper functions were used
skipNCharsandadvancePositionTo. WhereskipNChars(N)callsgetNextChar()N-times, whileadvancePositionTo(Ptr)is used insead ofCurPtr = Ptr.One helper function
isLabelTailwas moved into the Lexer class, to be able to check the bounds, and renamed togetLabelTailto better reflect it's function.