[WIP][DAG] visitFREEZE - always allow freezing multiple operands #152107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8365b9b to
f6e048a
Compare
8fc553e to
c80c4d2
Compare
715be61 to
0edc8b6
Compare
RKSimon
added a commit
to RKSimon/llvm-project
that referenced
this pull request
Aug 22, 2025
…te poison/undef Add AMDGPUTargetLowering::canCreateUndefOrPoisonForTargetNode handler and tag BFE_I32/U32 nodes as they can only propagate poison, not create poison/undef. Fighting some of the remaining regressions in llvm#152107 - need advice on the v_round_f64 change
0edc8b6 to
3b0856e
Compare
c7695aa to
4c5743a
Compare
RKSimon
added a commit
to RKSimon/llvm-project
that referenced
this pull request
Aug 26, 2025
…2P8AFFINEQB / GF2P8MULB handling All 3 instructions are well defined bit twiddling operations - they do not introduce undef/poison with well defined inputs. Fixes regressions in llvm#152107
4c5743a to
1d2fe46
Compare
b7dc70a to
c22f9a0
Compare
RKSimon
added a commit
to RKSimon/llvm-project
that referenced
this pull request
Aug 27, 2025
…NLOG handling Basic bitlogic operations don't create undef/poison. Its proving really annoying to create proper test coverage for these specific opcodes as they tend to appear in later stages - their presence does help in some upcoming patches (e.g. llvm#152107) and I'd prefer to get them committed early.
RKSimon
added a commit
that referenced
this pull request
Aug 27, 2025
…NLOG handling (#155600) Basic bitlogic operations don't create undef/poison. Its proving really annoying to create proper test coverage for these specific opcodes as they tend to appear in later stages - their presence does help in some upcoming patches (e.g. #152107) and I'd prefer to get them committed early.
c22f9a0 to
21092ff
Compare
960f95b to
3de4929
Compare
Remove the limited freeze multiple operand handling, always freeze all operands and rely on later visitFREEZE calls to merge frozen/unfrozen versions of each node to prevent infinite loops. This also removes the special handling of frozen SRA/SRL nodes as most of the regressions are related Fixes llvm#149798 Fixes llvm#150204
3de4929 to
5c050e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the limited freeze multiple operand handling, always freeze all operands and rely on later visitFREEZE calls to merge frozen/unfrozen versions of each node to prevent infinite loops.
This also removes the special handling of frozen SRA/SRL nodes as most of the regressions are related
Fixes #149798
Fixes #150204