-
Notifications
You must be signed in to change notification settings - Fork 14.9k
Move OpenACC Release Note- #154605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move OpenACC Release Note- #154605
Conversation
It was pointed out in the review that this ended up in the wrong place! Moving it. Note this is a modification of the 21.x release notes, so doesn't have a corresponding trunk change.
@llvm/pr-subscribers-clang Author: Erich Keane (erichkeane) ChangesIt was pointed out in the review that this ended up in the wrong place! Full diff: https://github.com/llvm/llvm-project/pull/154605.diff 1 Files Affected:
diff --git a/clang/docs/ReleaseNotes.rst b/clang/docs/ReleaseNotes.rst
index f4f7dd8342d92..72898c9f89623 100644
--- a/clang/docs/ReleaseNotes.rst
+++ b/clang/docs/ReleaseNotes.rst
@@ -997,6 +997,19 @@ Miscellaneous Clang Crashes Fixed
OpenACC Specific Changes
------------------------
+- OpenACC support, enabled via `-fopenacc` has reached a level of completeness
+ to finally be at least notionally usable. Currently, the OpenACC 3.4
+ specification has been completely implemented for Sema and AST creation, so
+ nodes will show up in the AST after having been properly checked. Lowering is
+ currently a work in progress, with compute, loop, and combined constructs
+ partially implemented, plus a handful of data and executable constructs
+ implemented. Lowering will only work in Clang-IR mode (so only with a compiler
+ built with Clang-IR enabled, and with `-fclangir` used on the command line).
+ However, note that the Clang-IR implementation status is also quite partial,
+ so frequent 'not yet implemented' diagnostics should be expected. Also, the
+ ACC MLIR dialect does not currently implement any lowering to LLVM-IR, so no
+ code generation is possible for OpenACC.
+
Target Specific Changes
-----------------------
@@ -1208,18 +1221,6 @@ New features
the runtime for the Blocks extension on Windows. This flag currently only
changes the code generation, and even then, only on Windows. This does not
impact the linker behaviour like the other `-static-*` flags.
-- OpenACC support, enabled via `-fopenacc` has reached a level of completeness
- to finally be at least notionally usable. Currently, the OpenACC 3.4
- specification has been completely implemented for Sema and AST creation, so
- nodes will show up in the AST after having been properly checked. Lowering is
- currently a work in progress, with compute, loop, and combined constructs
- partially implemented, plus a handful of data and executable constructs
- implemented. Lowering will only work in Clang-IR mode (so only with a compiler
- built with Clang-IR enabled, and with `-fclangir` used on the command line).
- However, note that the Clang-IR implementation status is also quite partial,
- so frequent 'not yet implemented' diagnostics should be expected. Also, the
- ACC MLIR dialect does not currently implement any lowering to LLVM-IR, so no
- code generation is possible for OpenACC.
- Implemented `P2719R5 Type-aware allocation and deallocation functions <https://wg21.link/P2719>`_
as an extension in all C++ language modes.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What a swift response. Thank you!
I hope I can get the other two entries also to their right places, but thats not your job. |
Was easy enough to do while I was there, reviews here: #154608 Feel free to add folks you think are good at reviewing these. |
Merged in 6989071 |
It was brought up in response to llvm#154605 that these two were in the wrong place as well! This patch tries to find better places for them, and moves them.
It was pointed out in the review that this ended up in the wrong place!
Moving it. Note this is a modification of the 21.x release notes, so
doesn't have a corresponding trunk change.