[clang] NFC: remove leftover from injected class name redecl #155959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code being removed became non-functional when injected class names were removed from the redecl chain in 470c454, but that commit didn't clean the code base out of all the workarounds for that state of affairs.
|
@llvm/pr-subscribers-clang Author: Matheus Izvekov (mizvekov) ChangesThe code being removed became non-functional when injected class names were removed from the redecl chain in 470c454, but that commit didn't clean the code base out of all the workarounds for that state of affairs. Full diff: https://github.com/llvm/llvm-project/pull/155959.diff 1 Files Affected:
diff --git a/clang/include/clang/AST/ASTNodeTraverser.h b/clang/include/clang/AST/ASTNodeTraverser.h
index d9dc8290b0e49..fe08d637a1e1d 100644
--- a/clang/include/clang/AST/ASTNodeTraverser.h
+++ b/clang/include/clang/AST/ASTNodeTraverser.h
@@ -649,21 +649,8 @@ class ASTNodeTraverser
template <typename SpecializationDecl>
void dumpTemplateDeclSpecialization(const SpecializationDecl *D) {
- for (const auto *RedeclWithBadType : D->redecls()) {
- // FIXME: The redecls() range sometimes has elements of a less-specific
- // type. (In particular, ClassTemplateSpecializationDecl::redecls() gives
- // us TagDecls, and should give CXXRecordDecls).
- auto *Redecl = dyn_cast<SpecializationDecl>(RedeclWithBadType);
- if (!Redecl) {
- // Found the injected-class-name for a class template. This will be
- // dumped as part of its surrounding class so we don't need to dump it
- // here.
- assert(isa<CXXRecordDecl>(RedeclWithBadType) &&
- "expected an injected-class-name");
- continue;
- }
- Visit(Redecl);
- }
+ for (const auto *Redecl : D->redecls())
+ Visit(cast<SpecializationDecl>(Redecl));
}
template <typename TemplateDecl>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code being removed became non-functional when injected class names were removed from the redecl chain in 470c454, but that commit didn't clean the code base out of all the workarounds for that state of affairs.