Skip to content

Conversation

kazutakahirata
Copy link
Contributor

getParent() already returns Function *.

getParent() already returns Function *.
@kazutakahirata kazutakahirata requested a review from nikic as a code owner August 29, 2025 05:19
@llvmbot llvmbot added the llvm:analysis Includes value tracking, cost tables and constant folding label Aug 29, 2025
@llvmbot
Copy link
Member

llvmbot commented Aug 29, 2025

@llvm/pr-subscribers-llvm-analysis

Author: Kazu Hirata (kazutakahirata)

Changes

getParent() already returns Function *.


Full diff: https://github.com/llvm/llvm-project/pull/155977.diff

1 Files Affected:

  • (modified) llvm/lib/Analysis/BasicAliasAnalysis.cpp (+3-3)
diff --git a/llvm/lib/Analysis/BasicAliasAnalysis.cpp b/llvm/lib/Analysis/BasicAliasAnalysis.cpp
index 86a2edbd8bd41..61f80103e55b5 100644
--- a/llvm/lib/Analysis/BasicAliasAnalysis.cpp
+++ b/llvm/lib/Analysis/BasicAliasAnalysis.cpp
@@ -227,9 +227,9 @@ EarliestEscapeAnalysis::getCapturesBefore(const Value *Object,
   auto Iter = EarliestEscapes.try_emplace(Object);
   if (Iter.second) {
     std::pair<Instruction *, CaptureComponents> EarliestCapture =
-        FindEarliestCapture(
-            Object, *const_cast<Function *>(DT.getRoot()->getParent()),
-            /*ReturnCaptures=*/false, DT, CaptureComponents::Provenance);
+        FindEarliestCapture(Object, *DT.getRoot()->getParent(),
+                            /*ReturnCaptures=*/false, DT,
+                            CaptureComponents::Provenance);
     if (EarliestCapture.first)
       Inst2Obj[EarliestCapture.first].push_back(Object);
     Iter.first->second = EarliestCapture;

@kazutakahirata kazutakahirata merged commit d3dcd0d into llvm:main Aug 29, 2025
11 checks passed
@kazutakahirata kazutakahirata deleted the cleanup_20250828_cast_Analysis branch August 29, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
llvm:analysis Includes value tracking, cost tables and constant folding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants