Skip to content

[flang-rt][device] Silence warning missing return statement at end of non-void function #156077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 29, 2025
Merged

[flang-rt][device] Silence warning missing return statement at end of non-void function #156077

merged 2 commits into from
Aug 29, 2025

Conversation

clementval
Copy link
Contributor

@clementval clementval commented Aug 29, 2025 •
edited
Loading

  • Silence warning when using FLANG_RT_EXPERIMENTAL_OFFLOAD_SUPPORT=CUDA

vzakhari
vzakhari approved these changes Aug 29, 2025
View reviewed changes
Copy link
Contributor

@vzakhari vzakhari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

klausler
klausler requested changes Aug 29, 2025
View reviewed changes
Copy link
Contributor

@klausler klausler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure that it makes sense to call llvm_unreachable() in the runtime??

Might be better to declare ReportUnsupportedChildIo as not returning.

@clementval
Copy link
Contributor Author

Are you sure that it makes sense to call llvm_unreachable() in the runtime??

Might be better to declare ReportUnsupportedChildIo as not returning.

Let me check if the compiler is happy with that.

@clementval
Copy link
Contributor Author

That works fine. Patch updated.

@clementval clementval enabled auto-merge (squash) August 29, 2025 18:54
@clementval clementval merged commit fb866f9 into llvm:main Aug 29, 2025
9 checks passed
@clementval clementval deleted the build_rt_warning branch August 29, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klausler klausler klausler approved these changes

@vzakhari vzakhari vzakhari approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clementval @klausler @vzakhari