Skip to content

Conversation

boomanaiden154
Copy link
Contributor

This patch enables the lit internal shell by default for testing flang-rt. The lit internal shell is able to run tests a bit faster as it avoids having to fork bash for every run line and also produces nicer debug information on failures.

This is part of #102704.

This patch enables the lit internal shell by default for testing
flang-rt. The lit internal shell is able to run tests a bit faster as it
avoids having to fork bash for every run line and also produces nicer
debug information on failures.

This is part of llvm#102704.
Copy link
Contributor

@clementval clementval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Does it work also on windows?

@boomanaiden154
Copy link
Contributor Author

Does it work also on windows?

The internal shell is the default on Windows, so this change should not have any impact on the Windows builds (theoretically).

@boomanaiden154 boomanaiden154 merged commit 317e9fc into llvm:main Aug 29, 2025
10 checks passed
@boomanaiden154 boomanaiden154 deleted the internal-shell-flang-rt branch August 29, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants