[RISCV] Add computeKnownBitsForTargetNode for RISCVISD::SRAW. #156191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This node reads the lower 32 bits, shifts it right arithmetically then sign extends to i64. If we know some of the lower 32 bits we can propagate that information. Test case is a little contrived because I had to find something that didn't get optimized before type legalizaton and didn't get type legalized to a sign extending operation.
|
@llvm/pr-subscribers-backend-risc-v Author: Craig Topper (topperc) ChangesThis node reads the lower 32 bits, shifts it right arithmetically For the test case I had to find something that didn't get optimized Full diff: https://github.com/llvm/llvm-project/pull/156191.diff 2 Files Affected:
diff --git a/llvm/lib/Target/RISCV/RISCVISelLowering.cpp b/llvm/lib/Target/RISCV/RISCVISelLowering.cpp
index 9c268012b24d2..9115c1385d6df 100644
--- a/llvm/lib/Target/RISCV/RISCVISelLowering.cpp
+++ b/llvm/lib/Target/RISCV/RISCVISelLowering.cpp
@@ -21379,6 +21379,15 @@ void RISCVTargetLowering::computeKnownBitsForTargetNode(const SDValue Op,
Known = Known.sext(BitWidth);
break;
}
+ case RISCVISD::SRAW: {
+ KnownBits Known2;
+ Known = DAG.computeKnownBits(Op.getOperand(0), DemandedElts, Depth + 1);
+ Known2 = DAG.computeKnownBits(Op.getOperand(1), DemandedElts, Depth + 1);
+ Known = KnownBits::ashr(Known.trunc(32), Known2.trunc(5).zext(32));
+ // Restore the original width by sign extending.
+ Known = Known.sext(BitWidth);
+ break;
+ }
case RISCVISD::CTZW: {
KnownBits Known2 = DAG.computeKnownBits(Op.getOperand(0), Depth + 1);
unsigned PossibleTZ = Known2.trunc(32).countMaxTrailingZeros();
diff --git a/llvm/test/CodeGen/RISCV/rv64i-shift-sext.ll b/llvm/test/CodeGen/RISCV/rv64i-shift-sext.ll
index 90735d88494b5..b23f4f5812000 100644
--- a/llvm/test/CodeGen/RISCV/rv64i-shift-sext.ll
+++ b/llvm/test/CodeGen/RISCV/rv64i-shift-sext.ll
@@ -235,3 +235,28 @@ define signext i32 @test15(i32 signext %x, i32 signext %y) {
%c = shl i32 %b, 1
ret i32 %c
}
+
+define signext i32 @test16(i32 signext %x, i32 signext %y) {
+; RV64I-LABEL: test16:
+; RV64I: # %bb.0:
+; RV64I-NEXT: ori a2, a0, 192
+; RV64I-NEXT: srli a3, a0, 8
+; RV64I-NEXT: lui a4, 16
+; RV64I-NEXT: srliw a0, a0, 24
+; RV64I-NEXT: addi a4, a4, -256
+; RV64I-NEXT: and a3, a3, a4
+; RV64I-NEXT: and a4, a2, a4
+; RV64I-NEXT: or a0, a3, a0
+; RV64I-NEXT: slli a4, a4, 8
+; RV64I-NEXT: slli a2, a2, 24
+; RV64I-NEXT: or a2, a2, a4
+; RV64I-NEXT: or a0, a2, a0
+; RV64I-NEXT: sraw a0, a0, a1
+; RV64I-NEXT: slli a0, a0, 1
+; RV64I-NEXT: ret
+ %a = or i32 %x, 192
+ %d = call i32 @llvm.bswap.i32(i32 %a)
+ %b = ashr i32 %d, %y
+ %c = shl i32 %b, 1
+ ret i32 %c
+}
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This node reads the lower 32 bits, shifts it right arithmetically
then sign extends to i64. If we know some of the lower 32 bits we
can propagate that information.
For the test case I had to find something that didn't get optimized
before type legalizaton and didn't get type legalized to a sign
extended value. The bswap gets type legalized to (lshr (bswap), 32).