[ADT] Mark BitVector::find_prev_unset const (NFC) #156272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
find_prev_unset calls find_last_unset_in, a const method, but find_prev_unset itself isn't marked const.
|
@llvm/pr-subscribers-llvm-adt Author: Kazu Hirata (kazutakahirata) Changesfind_prev_unset calls find_last_unset_in, a const method, but Full diff: https://github.com/llvm/llvm-project/pull/156272.diff 1 Files Affected:
diff --git a/llvm/include/llvm/ADT/BitVector.h b/llvm/include/llvm/ADT/BitVector.h
index 70de4c239c1c7..1fbce1a95fb76 100644
--- a/llvm/include/llvm/ADT/BitVector.h
+++ b/llvm/include/llvm/ADT/BitVector.h
@@ -327,7 +327,7 @@ class BitVector {
/// find_prev_unset - Returns the index of the first unset bit that precedes
/// the bit at \p PriorTo. Returns -1 if all previous bits are set.
- int find_prev_unset(unsigned PriorTo) {
+ int find_prev_unset(unsigned PriorTo) const {
return find_last_unset_in(0, PriorTo);
}
|
arsenm
approved these changes
Sep 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
find_prev_unset calls find_last_unset_in, a const method, but
find_prev_unset itself isn't marked const.